feat: drop Node 10 support #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
MichaelDeBoey
force-pushed
the
patch-5
branch
from
b949df0 to
7ac06ac
Compare
|
Ping @xjamundx |
|
Yeah I'm fine with this for the version 8 support release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to update our
eslint-plugin-eslint-plugindependency to v4, we also needNode@^12.22.0 || ^14.17.0 || >=16.0.0https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/6c58c91cefffd5433a01d90f802e9152cdebbcdd/package.json#L70-L72
Node 10 is EOL, so it's a good practice to not support it anymore.
ESLint 8.x requires
Node@^12.22.0 || ^14.17.0 || >=16.0.0and imo it's a good practice to keep the Node version equal to that of the latest supported ESLint versionhttps://github.com/eslint/eslint/blob/fa4d4830a0e77f92154079ada17ffb893ce64232/package.json#L146-L148
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
This branch is dependent on #227